Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce passing context to super in class constructor #4

Open
miklschmidt opened this issue May 1, 2017 · 2 comments
Open

Enforce passing context to super in class constructor #4

miklschmidt opened this issue May 1, 2017 · 2 comments

Comments

@miklschmidt
Copy link
Member

This is especially important for relay classes.

@kastermester
Copy link
Member

We need to figure out if this always applies or not. I suspect something else was the actual bug here (but I'm not sure).

At the very least however, we should create a rule that enforces this when referencing this.context inside the react class.

@miklschmidt
Copy link
Member Author

Yes, i think it actually wasn't the source of the problem. There's probably documentation somewhere that explains when it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants