New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The order of headers #129

Closed

maths644311798 opened this issue Aug 31, 2023 · 1 comment

Contributor

maths644311798 commented Aug 31, 2023

The order of headers in /yacl/link/transport/interconnection_base.cc is not good.

#include "yacl/link/transport/interconnection_base.h"

will actually include "spdlog/spdlog.h". But

#include "fmt/ostream.h"

should be above "spdlog/spdlog.h". See also gabime/spdlog#2872 (comment)

Contributor

anakinxc commented Aug 31, 2023

This is a bug in fmt/spdlog, not yacl.

anakinxc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment