Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: add options allowAWSAccessKeyID and allowAWSAccountID #54

Closed
azu opened this issue Feb 26, 2020 · 4 comments
Closed

aws: add options allowAWSAccessKeyID and allowAWSAccountID #54

azu opened this issue Feb 26, 2020 · 4 comments
Labels
Status: Proposal Request for comments

Comments

@azu
Copy link
Member

azu commented Feb 26, 2020

We need to add configuratio for AWSAccountID and AWSAccessKeyID rule.
It will make false-positive, So user want to configura this rule.

https://github.com/secretlint/secretlint/tree/master/packages/%40secretlint/secretlint-rule-aws#rules
@azu
Copy link
Member Author

azu commented Feb 26, 2020

{ allowMessage: ["AWSAccountID"] } is another option as #3

@azu
Copy link
Member Author

azu commented Feb 27, 2020

We will implement message(ID) filter instead of allow options.

@azu azu added the Status: Proposal Request for comments label Feb 27, 2020
@azu azu mentioned this issue Feb 27, 2020
Merged
@azu
Copy link
Member Author

azu commented Feb 28, 2020

This option will be replaced with allowMessages #59

@azu
Copy link
Member Author

azu commented Feb 28, 2020

fi

@azu azu closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Proposal Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azu