Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SigstoreSigner: define URI and some import functionality #533

Closed
jku opened this issue Mar 13, 2023 · 1 comment
Closed

SigstoreSigner: define URI and some import functionality #533

jku opened this issue Mar 13, 2023 · 1 comment
Assignees

Comments

@jku
Copy link
Collaborator

jku commented Mar 13, 2023

NOTE: SigstoreSigner is unstable and will likely stay that way for a bit.... It's already very interesting though so would be nice to to start implementing the quality of life improvements:

  • signer should define a private key URI. As far as I can tell it should only encode whether the signing should use ambient credentials or not -- other suggestions are welcome though. So maybe just sigstore:?ambient=true or sigstore:?ambient=false
  • from_priv_key_uri() would either use detect_credentials() or issuer.identity_token() based on ambient value
  • the generic import method would take identity, issuer and ambient as arguments and return a public key (with a generated keyid) and URI

Further improvements:

  • later down the line we may want to provided more specific helpers like e.g. import_github_action() that could take repository, workflow and branch name instead (because constructing the identity string is a bit complex)
  • signing really should be able to choose the identity and issuer -- user should not be able to choose GitHub as the issuer if we know we want issuer to be Google: user should only decide to authenticate or not.
@lukpueh
Copy link
Member

lukpueh commented Mar 16, 2023

Mostly addressed by #535. Further improvements ticketized in #536 and #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants