Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefectDojo Hook: Allow setting minimum severity on Import #1700

Closed
malexmave opened this issue Apr 21, 2023 · 0 comments · Fixed by #1775
Closed

DefectDojo Hook: Allow setting minimum severity on Import #1700

malexmave opened this issue Apr 21, 2023 · 0 comments · Fixed by #1775
Assignees
Labels
defectdojo All issues regarding the DefectDojo Integration hook Implement or update a hook persistence Implement or update a persistence store

Comments

@malexmave
Copy link
Member

➹ New Feature implementation request

At the moment, the DefectDojo hook is importing all findings into DefectDojo. Both the scan_import and the reimport_scan endpoints have an optional parameter minimum_severity that controls the minimum finding severity that should be imported. This allows the user to ensure that the DefectDojo is not flooded with hundreds of thousands of informational findings from verbose scanners.

Describe the solution you'd like

Allow the user to set the minimum_severity parameter as part of the hook configuration. Document that this may have undesireable side effects in the following cases (plus any others you may find):

  • When syncFindingsBack is enabled, I assume that removing INFO findings from the import will also remove them from the synced back findings, leading to fewer targets to cascade on. Solution: Use read-only mode (syncFindingsBack=false)
  • Some scan types may not support severities, for example the generic scan importer. Here, the behavior of the endpoint would need to be tested and documented to avoid surprising the user.
  • There may be other side effects I didn't consider here.

Describe alternatives you've considered

It doesn't seem to be possible to configure this on the side of DefectDojo (and even if it were, the same side effects may apply).

@malexmave malexmave added enhancement New feature or request defectdojo All issues regarding the DefectDojo Integration labels Apr 21, 2023
@rseedorff rseedorff added persistence Implement or update a persistence store hook Implement or update a hook and removed enhancement New feature or request labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defectdojo All issues regarding the DefectDojo Integration hook Implement or update a hook persistence Implement or update a persistence store
Projects
Archived in project
3 participants