Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ZAP Advanced and ZAP Baseline #1851

Closed
Weltraumschaf opened this issue Aug 7, 2023 · 7 comments
Closed

Deprecate ZAP Advanced and ZAP Baseline #1851

Weltraumschaf opened this issue Aug 7, 2023 · 7 comments
Labels
breaking Changes requiring a major release enhancement New feature or request

Comments

@Weltraumschaf
Copy link
Member

We do not want to maintain this anymore, in favor of ZAP Automaton framework.

@Weltraumschaf
Copy link
Member Author

Depends on:#1902

@Weltraumschaf
Copy link
Member Author

We can set Helm charts deprecated: https://helm.sh/docs/topics/charts/#deprecating-charts

@moxli
Copy link
Contributor

moxli commented Dec 8, 2023

@Weltraumschaf I notice when using the automation framework in additon with DefectDojo that the importer used there is not the ZAP scan one but rather the Generic findings import.
Is this intentional or something where compatibility is missing with SecureCodeBox or DefectDojo?

@J12934
Copy link
Member

J12934 commented Dec 8, 2023

@moxli oh no that is probably a missing config in the defectdojo hook. The automation framework also produces the same json as the other zap types and should be compatible.

The mapping for the hook is here: https://github.com/secureCodeBox/secureCodeBox/blob/main/hooks/persistence-defectdojo/hook/src/main/java/io/securecodebox/persistence/util/ScanNameMapping.java

@moxli
Copy link
Contributor

moxli commented Dec 8, 2023

@J12934 Thanks, I have created an issue to track this.

@Weltraumschaf
Copy link
Member Author

Hi @moxli,

sorry, I completely missed your message here 🙈

@Weltraumschaf
Copy link
Member Author

Resolved by #1902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes requiring a major release enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants