Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide the download button #30

Closed
rajeshgutta opened this issue Apr 3, 2018 · 3 comments
Closed

hide the download button #30

rajeshgutta opened this issue Apr 3, 2018 · 3 comments
Assignees
@securedeveloper
Labels
enhancement help needed

Comments

@rajeshgutta
Copy link
Contributor

Hi,

Thanks for building this awesome package. I want to make a small change where we give a prop to hide the download button. So if we have a prop hideElement set to true on ExcelFile, we directly download the file without rendering the download button. I made the change and have a branch ready. Please let me know how I can push the changes and create a Pull request for this.
@securedeveloper
Copy link
Owner

Hello @rajeshgutta, I am happy that you wish to contribute to this project. Please follow these rules to contribute, and let me know if you are still unable to do it.

@securedeveloper securedeveloper self-assigned this Apr 3, 2018
@securedeveloper
Copy link
Owner

securedeveloper commented Apr 4, 2018 •
edited
Loading

We just released your change in our latest deployment 🎉 ㊗️

@ganesh-sanap
Copy link

@securedeveloper, @rajeshgutta
Can we show/hide or disable download button based on the length of data array (disable button if array is empty and enable button click and download file if there is data in array)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@securedeveloper securedeveloper

Labels
enhancement help needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@securedeveloper @rajeshgutta @ganesh-sanap