Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Add Gif to the README #245

Closed
wants to merge 1 commit into from
Closed

Add Gif to the README #245

wants to merge 1 commit into from

Conversation

MVrachev
Copy link
Contributor

@MVrachev MVrachev commented Jun 20, 2019

It will be really useful if we add a GIF to the Precaution README.
That way we would show how Precaution works in 17 seconds!

Closes: #106

Signed-off-by: Martin Vrachev mvrachev@vmware.com

@MVrachev MVrachev requested a review from joshuagl June 20, 2019 19:14
It will be really useful if we add a GIF to the Precaution README.
That way we would show how Precaution works in 17 seconds!

Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
Copy link
Collaborator

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GIF is very large. Any way to reduce it's size?

@joshuagl
Copy link
Contributor

ImageOptim wraps a bunch of image compression tools in a macOS GUI

@MVrachev
Copy link
Contributor Author

MVrachev commented Jul 15, 2019

I tried to export all images in 720 p, them I used ImageOptim as @joshuagl suggested and in the end, I combined them with gifsky. On Gifsky I set it with a quality of 50 %.
The result is blurred Gif which is 30 MB in size.

I don't know how to shrink it more.

@joshuagl
Copy link
Contributor

joshuagl commented Aug 2, 2019

As the Gif is so large and adding large binaries to a git repo isn't good practice, can we instead upload the video to YouTube or similar and embed it in the README?

@ericwb
Copy link
Collaborator

ericwb commented Aug 7, 2019

@joshuagl
Copy link
Contributor

joshuagl commented Aug 7, 2019

This does seem like a good use-case for Git LFS, we gain the benefits of a Gif embedded in the README without having to worry about the impact of a large file on our git repository.

Copy link
Contributor

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested, we should look at Git LFS for the Gif

@joshuagl joshuagl added the work-in-progress Pull request that is still in progress and shouldn't be merged label Sep 23, 2019
@MVrachev MVrachev closed this Aug 23, 2020
@MVrachev MVrachev deleted the gif branch August 23, 2020 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
work-in-progress Pull request that is still in progress and shouldn't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated Gif on README
3 participants