Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to documentation #117

Merged
merged 1 commit into from Nov 10, 2021
Merged

Add to documentation #117

merged 1 commit into from Nov 10, 2021

Conversation

chris-ricketts
Copy link
Collaborator

First in a series of commits to update the documentation.

Please don't merge yet, I will keep adding to this PR and the additions can be reviewed piecemeal.

@FloppyDisck FloppyDisck added the oracle New feature or request for the oracle contract label Oct 12, 2021
@FloppyDisck
Copy link
Contributor

Is the PR ready?

@chris-ricketts
Copy link
Collaborator Author

@FloppyDisck

Is the PR ready

I think this PR is obsolete for a couple of reasons:

  • The main branch is fairly behind the dev branch, even the oracle contract interface could change.
  • If doc2book tool  #123 is accepted, this documentation should be generated by that script and each contract README can link to the published book.

I suppose there's no harm in merging it or it can just be closed.

@mohammedpatla mohammedpatla merged commit 22301e5 into securesecrets:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPresident DrPresident DrPresident approved these changes

@FloppyDisck FloppyDisck FloppyDisck approved these changes

Assignees
No one assigned
Labels
oracle New feature or request for the oracle contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris-ricketts @FloppyDisck @DrPresident @mohammedpatla