Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonds audit #237

Merged
merged 10 commits into from Jul 26, 2022
Merged

Bonds audit #237

merged 10 commits into from Jul 26, 2022

Conversation

wahlbergkyle
Copy link
Contributor

Description

Responding to Certik audit of Bonds contract, as well as adding fix to allow for stkd-SCRT compatibility.

Notable changes

  • User account created based off of "from", not "sender" when assets are deposited
  • fetch_snip20 now won't error out if token_config DNE
  • HandleResponse from update_config and update_limit_config improved

@wahlbergkyle
Copy link
Contributor Author

Test failed in the same way "main" currently is. This only concerns bonds audit commits, hence that failure remains.

@FloppyDisck
Copy link
Contributor

This should be merged into dev and then into main

@FloppyDisck FloppyDisck changed the base branch from main to dev July 26, 2022 17:32
@wahlbergkyle wahlbergkyle merged commit 5cf83fd into dev Jul 26, 2022
@wahlbergkyle wahlbergkyle deleted the Bonds-Audit branch July 26, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloppyDisck FloppyDisck FloppyDisck approved these changes

@SissonJ SissonJ SissonJ approved these changes

@DrPresident DrPresident Awaiting requested review from DrPresident

@mohammedpatla mohammedpatla Awaiting requested review from mohammedpatla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wahlbergkyle @FloppyDisck @SissonJ