Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio of peer's video is wrong #32

Open
darioalessandro opened this issue May 20, 2023 · 7 comments
Open

Aspect ratio of peer's video is wrong #32

darioalessandro opened this issue May 20, 2023 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@darioalessandro
Copy link
Member

The aspect ratio is hardcoded.

Instead, the code should lazily adapt to the aspect ratio of the decoded images.

Screen Shot 2023-05-20 at 12 34 40 PM
@darioalessandro darioalessandro added good first issue Good for newcomers help wanted Extra attention is needed labels May 20, 2023
@vitorsgoncalves
Copy link

Hello. I came across your post on reddit, and I'd like to contribute. I believe this issue can be a good stating point, right?

@darioalessandro
Copy link
Member Author

yes!! thank you so much for reaching out brother!!

@darioalessandro
Copy link
Member Author

@vitorsgoncalves the main issue is that the encoder's resolution is hardcoded, we do not even look at the aspect ratio that the device has: https://github.com/security-union/zoom-rs/blob/9a551e33412ab9169273dddbeecd9978a3713d20/yew-ui/src/components/host.rs#L425-L426

@darioalessandro
Copy link
Member Author

@vitorsgoncalves are you planning to take on this feature?

@vitorsgoncalves
Copy link

vitorsgoncalves commented Jun 29, 2023 via email

@vitorsgoncalves
Copy link

I'm sorry, but I won't have much time to work on this from now on, and still didn't make much progress. I think it's better to let you assign someone else.

@darioalessandro
Copy link
Member Author

Ok no worries, care to share what you tried?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants