Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSAFajv #58

Open
tschmidtb51 opened this issue Aug 31, 2022 · 3 comments
Open

CSAFajv #58

tschmidtb51 opened this issue Aug 31, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@tschmidtb51
Copy link
Contributor

Why do we use an AJV with strict=false for the schema validation? Shouldn't the strict_schema be checked with the strict option?

@domachine: Something to discuss in the meeting.

@tschmidtb51 tschmidtb51 added the question Further information is requested label Aug 31, 2022
@tschmidtb51
Copy link
Contributor Author

As discussed in the meeting: Check whether the schema compiles with strict=true.

@domachine
Copy link
Contributor

There seems to be a problem with the license keyword used in the cvss schemas. When compiling with strict: true I get the following error:

Error: strict mode: unknown keyword: "license"
    at checkStrictMode (/Users/dominik/Desktop/repos/github.com/secvisogram/csaf-validator-lib/node_modules/ajv/dist/compile/util.js:174:15)
    at checkUnknownRules (/Users/dominik/Desktop/repos/github.com/secvisogram/csaf-validator-lib/node_modules/ajv/dist/compile/util.js:32:13)
    at checkKeywords (/Users/dominik/Desktop/repos/github.com/secvisogram/csaf-validator-lib/node_modules/ajv/dist/compile/validate/index.js:120:34)
    at validateFunctionCode (/Users/dominik/Desktop/repos/github.com/secvisogram/csaf-validator-lib/node_modules/ajv/dist/compile/validate/index.js:19:9)
...

@tschmidtb51 tschmidtb51 self-assigned this Nov 2, 2022
@tschmidtb51
Copy link
Contributor Author

Thanks for digging into it. That would require the FIRST CVSS SIG to change their JSON schema. At the moment this can't be implemented.

We'll start a discussion with the FIRST CVSS SIG at the appropriate time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants