Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test on add and delete functionality #4

Merged
merged 1 commit into from Feb 24, 2022
Merged

Conversation

chukwuebukaVictor
Copy link
Collaborator

Todo-list test

  • Add a unit test on add functionality using jest
  • Add a unit test on delete functionality using jest
  • Add a unit test on local storage jest

Copy link

@Hamzaoutdoors Hamzaoutdoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chukwuebukaVictor,

Congratulations! 🎉 Project Approved ✅

Your project is complete! There is nothing else to say other than... it's time to merge it 🚀

To Highlight:

  • The Pull Request has a proper title and description. ✔️
  • You have added a descriptive Readme file. Good Job. ✔️
  • There is no linter error is present. ✔️
  • Project has met all the technical aspects you needed for this project! ✔️
  • 4 unit tests have been passed ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • I recommend you to collect your Unit Test files into a tests folder,

Cheers and Happy coding and Keep rocking! 👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@chukwuebukaVictor chukwuebukaVictor merged commit fb21f2e into main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants