Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update benchmarks for js-framework-benchmark #441

Open
2 tasks
akhilman opened this issue May 5, 2020 · 2 comments
Open
2 tasks

Add/update benchmarks for js-framework-benchmark #441

akhilman opened this issue May 5, 2020 · 2 comments

Comments

@akhilman
Copy link
Member

akhilman commented May 5, 2020

  • Update non keyed benchmarks.
  • Implement keyed benchmarks.

The key benchmark cannot be fully implemented (see krausest/js-framework-benchmark#694). Our keyed VDOM implementation recreates one of the swapped element. The reason for this choice is that the browser still recalculates the element when it is moved inside the DOM.

Possible solutions:

  • Keep our implementation as is and add a note about this to the benchmark.
  • Postpone the removal of elements and reuse them in a new location if needed.
@MartinKavik
Copy link
Member

MartinKavik commented May 5, 2020

When I was linting non-keyed implementation by benchmark's linter, it said that Seed behavior isn't strictly non-keyed. So the results aren't 100% comparable because each framework uses different algorithms.
So.. if you think VDOM modification will make it better and helps to improve user apps - I'm ok with it. If we want to change VDOM to satisfy this benchmark, we shouldn't do it.

@rebo
Copy link
Collaborator

rebo commented May 9, 2020

Definitely agree do what's best for the user not an artificial benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants