Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto expand rows #24

Closed
GJNilsen opened this issue May 27, 2016 · 2 comments
Closed

Auto expand rows #24

GJNilsen opened this issue May 27, 2016 · 2 comments

Comments

@GJNilsen
Copy link

GJNilsen commented May 27, 2016

When running the app on iPhone 6, after adding the third picture, it should be on a line below, instead of scrolling off to the side. The same way the text entry field expands downwards, the container of the cells should also expand accordingly.
(BTW, fantastic work done on the StackViewController)

@jessedc
Copy link

jessedc commented May 27, 2016

The demo app's implementation (ImageAttachmentView) uses a UIStackView in a container to deliberately lay out the thumbnail images horizontally in a single row to demonstrate the scrolling functionality of the stack view container class.

I think dropping additional icons onto new lines removes part of the demo app's functionality (as a demo) and is slightly outside of the scope of the demo project.

FWIW, UIStackView is documented to be limited to a single row or column, unlike UICollection view see Apple's docs on UIStackView:

The UIStackView class provides a streamlined interface for laying out a collection of views in either a column or a row

@indragiek
Copy link
Contributor

@GJNilsen This was intentional, as explained by @jessedc (thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants