Limit source file types to Swift and headers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the Info.plist file from this repo was included in the compile sources phase, which causes a build failure with the new Xcode 9 build system.
vikmeup
reviewed
Aug 25, 2017
SeedStackViewController.podspec
Outdated
| @@ -12,6 +12,6 @@ StackViewController is a Swift framework that simplifies the process of building | |||
| s.author = { "Indragie Karunaratne" => "i@indragie.com" } | |||
| s.source = { :git => "https://github.com/seedco/StackViewController.git", :tag => s.version.to_s } | |||
| s.ios.deployment_target = '9.0' | |||
| s.source_files = 'StackViewController/**' | |||
| s.source_files = 'StackViewController/**/*.{h,swift}' | |||
There was a problem hiding this comment.
@mergesort thank you for the PR!
Did you mean to have source files set to StackViewController/*.{h,swift} ?
There was a problem hiding this comment.
Yes, my mistake. Lemme tweak that.
|
Updated with the right file path. |
vikmeup
approved these changes
Aug 25, 2017
|
@vikmeup I just realized that I didn't bump the version number. Would it make sense to give it a version number of 0.3.1 in another patch? I don't have CocoaPods push access, so it would make sense to come from your side if you do choose to do that. Thanks! |
|
@mergesort I had problems running |
|
@mergesort done! version 0.3.1 successfully published. |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the Info.plist file from this repo was included in the compile sources phase, which causes a build failure with the new Xcode 9 build system.