Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pls add android 10 as a requirement (wiki) #106

Closed
steadfasterX opened this issue Jul 27, 2020 · 7 comments
Closed

pls add android 10 as a requirement (wiki) #106

steadfasterX opened this issue Jul 27, 2020 · 7 comments

Comments

@steadfasterX
Copy link
Contributor

  1. add requirements topic #105
  2. https://github.com/stevesoltys/seedvault/wiki/Building-with-AOSP (requirements topic)

after digging around with the aosp inline build I found that it simply does not work. thx to #97 I got the confirmation that android 10 is needed.
so I switched to prebuilt and now realized that ofc that will not work as well (hoped that the a10 req would be just related to building..):

01-02 07:50:17.629 1070 1070 W PackageManager: Failed to parse /system/priv-app/Seedvault: /system/priv-app/Seedvault/Seedvault.apk (at Binary XML file line #7): Requires newer sdk version #29 (current version is #28)

it would have saved me a lot of time when the above 2 things would have been there.

btw any chance to get that running in PIE ever?

@grote
Copy link
Collaborator

grote commented Jul 27, 2020

We only support the latest Android version and explained somewhere else why. You can still use and maintain older versions. In the future we might branch out branches per AOSP version. An android9 branch would have been branched out before 37ffacb for example.

@steadfasterX
Copy link
Contributor Author

steadfasterX commented Jul 27, 2020

yes. but that is not mentioned in the README and is not mentioned in the build guide. so it is missing IMHO in the most prominent places where a user would look first (instead of digging into commits etc)

thats why I created the above PR and if I would have wiki access I would have done the same there as well. it would be just a small simple hint but it will help everybody starting with this.

@grote
Copy link
Collaborator

grote commented Jul 27, 2020

Yep help with documenting this is very much appreciated. Thanks!

@steadfasterX
Copy link
Contributor Author

steadfasterX commented Jul 27, 2020

@grote what is the best way to get help getting it work in pie?
I have reverted the android10 commit and fixed build issues here

but I need someone with more knowledge then me to verify that this was made correctly or completely stupid :P
at least it builds now :) (but as said do not show up at all)

@grote
Copy link
Collaborator

grote commented Aug 6, 2020

@steadfasterX maybe talk to @stevesoltys if he let's you maintain an android9 branch.

As for making sure it works, I'd start with the instrumentation and unit tests followed by actual on-device testing.

@stevesoltys
Copy link
Member

I'm okay with an Android 9 branch.

There won't be any prebuilt repo for it, but since this is now inline, that should be fine.

@steadfasterX
Copy link
Contributor Author

closing that issue as #105 got merged and wiki is updated, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants