Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occurrences in DST change hour get skipped #150

Closed
avit opened this issue Feb 23, 2013 · 0 comments
Closed

Occurrences in DST change hour get skipped #150

avit opened this issue Feb 23, 2013 · 0 comments
Labels

Comments

@avit
Copy link
Collaborator

avit commented Feb 23, 2013

I found that a 2AM rule would get skipped as it traverses the DST boundary:

schedule = IceCube::Schedule.new(Time.local(2013, 3, 9, 2, 0, 0))
schedule.rrule IceCube::Rule.daily
schedule.first(2)
# => [2013-03-09 02:00:00 -0800, 2013-03-11 02:00:00 -0700]

The occurrence on March 10th gets skipped. Instead of skipping a day because there's no 2AM there, It should validate the nearest hour (3AM). This applies to all recurrence rules.

When hour_of_day(2) is specified as an override to the schedule start time it seems that it should also consider DST changes and use the nearest hour, based on section 3.3.5 and referenced in 3.3.10 for BYHOUR on page 45.

@avit avit closed this as completed in 8ef656b Feb 23, 2013
rlivsey pushed a commit to rlivsey/ice_cube that referenced this issue Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant