Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

occurs_on? misses when time is near midnight #245

Merged
merged 1 commit into from Jul 6, 2014
Merged

occurs_on? misses when time is near midnight #245

merged 1 commit into from Jul 6, 2014

Commits on Jul 6, 2014

  1. Fix DST offset for occurs_on using local times 

    When building a new time for `beginning_of_date` / `end_of_date` we now
use `Time.local` or `Time.utc` correctly to apply the right offset for
the time of year (in absence of ActiveSupport). Previously, only a
"non-local" time with a fixed offset was was applied so a reference time
6 months from the target date could have the wrong DST offset applied.

This now matches the same order of zone lookup used in `match_zone`.
The fallback is to use the fixed offset only when no correct zone
information is available.
    @avit
    avit committed Jul 6, 2014
    Copy the full SHA
    41ff84a View commit details
    Browse the repository at this point in the history