This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
fix(deps): Always use latest version of html-sketchapp #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdalgleish
changed the title
markdalgleish
changed the title
markdalgleish
changed the title
michaeltaranto
approved these changes
Apr 4, 2018
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use html-sketchapp in a browser context, we need to compile it into a browser-compatible script file. Currently, we do this by running the script through webpack before publishing to npm.
The downside of this approach is that consumers are locked to the version of html-sketchapp that we bundle at publish time. If a new version of html-sketchapp is released, it won't be available to consumers of this tool until we trigger another release.
To fix this, we now run the script through Rollup at runtime, which means that it's always using the version of html-sketchapp that's currently installed in
node_modules.Since it's now possible that an html-sketchapp update could cause the compilation step to fail, I'm also adding a Renovate config so that we keep up with downstream updates and ensure that the build continues to pass.