Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'openBrowser' config option #15

Merged
merged 1 commit into from Nov 19, 2018
Merged

feat: Add 'openBrowser' config option #15

merged 1 commit into from Nov 19, 2018

Conversation

pascalduez
Copy link
Contributor

@pascalduez pascalduez commented Nov 17, 2018

  • Add a new no-open command line option

Sadly I couldn't go with a more straightforward option like --open since command-line-args disallow configurable Boolean options like --open=false. See 75lb/command-line-args#71

The other solution is --open=on|off

Or using --open but changing the current behavior and not forcing it by default.
My preference :)

Note: The config key will override the command line option, if any

@markdalgleish
Copy link
Member

markdalgleish commented Nov 18, 2018

Thanks for this PR too! 😄

Similarly to #14, would you be able to implement this as an openBrowser option in the config file, with a default value of true? I'd still like to keep the default behaviour, since it's a much better experience for newcomers to the project who won't know which URL to open.

- With an `openBrowser` config file key
@markdalgleish markdalgleish changed the title feat: Allow configuring default open in browser feat: Add 'openBrowser' config option Nov 19, 2018
@markdalgleish markdalgleish merged commit b0b030f into seek-oss:master Nov 19, 2018
@markdalgleish
Copy link
Member

Published as v0.4.0. Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants