Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update/switch friendly-errors-webpack-plugin #239

Merged
merged 2 commits into from Sep 24, 2021

Conversation

mihkeleidast
Copy link
Contributor

This fixes a peerDependency mismatch warning when installing playroom:

npm WARN friendly-errors-webpack-plugin@1.7.0 requires a peer of webpack@^2.0.0 || ^3.0.0 || ^4.0.0 but none is installed. You must install peer dependencies yourself.

Since the original plugin is unmaintained (repo is even archived), I switched the used package to the most popular fork. Having no peerDependency warnings is quite important to me, as we're planning to move to npm@7, where these kinds of mismatches throw errors.

@mihkeleidast mihkeleidast requested a review from a team as a code owner September 13, 2021 11:12
Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks 👏

@michaeltaranto michaeltaranto merged commit 05729cf into seek-oss:master Sep 24, 2021
@mihkeleidast mihkeleidast deleted the update-friendly-errors branch September 30, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants