Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse tsconfig #242

Merged
merged 3 commits into from Sep 24, 2021
Merged

fix: Parse tsconfig #242

merged 3 commits into from Sep 24, 2021

Conversation

AndrewLeedham
Copy link
Contributor

@AndrewLeedham AndrewLeedham commented Sep 13, 2021 •
edited

fixes: #241

Fully parses found tsconfig so things like extends are resolved by the TypeScript API. This is the same way react-docgen-typescript does things when using withCustomConfig instead of withCompilerOptions.

@AndrewLeedham AndrewLeedham marked this pull request as ready for review September 13, 2021 23:25
@AndrewLeedham AndrewLeedham requested a review from a team as a code owner September 13, 2021 23:25
michaeltaranto
michaeltaranto approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for doing this 👏

@michaeltaranto michaeltaranto enabled auto-merge (squash) September 24, 2021 11:47
@michaeltaranto michaeltaranto merged commit 27d7158 into seek-oss:master Sep 24, 2021
@pascalduez pascalduez mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltaranto michaeltaranto michaeltaranto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript configurations not fully parsed
2 participants
@AndrewLeedham @michaeltaranto