Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent exception on start when no TS config is found #248

Merged
merged 2 commits into from Dec 1, 2021
Merged

fix: prevent exception on start when no TS config is found #248

merged 2 commits into from Dec 1, 2021

Conversation

pascalduez
Copy link
Contributor

@pascalduez pascalduez commented Oct 4, 2021 •
edited

This PR should fix #247

undefined is passed to path.dirname, on projects with no TS config file.

@pascalduez pascalduez requested a review from a team as a code owner October 4, 2021 15:11
AndrewLeedham
AndrewLeedham approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@AndrewLeedham AndrewLeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@danchristian
Copy link

danchristian commented Nov 10, 2021 •
edited

Can this get merged? Otherwise 0.27.7 is unusable.

@artmsilva
Copy link

Bumping this. We would like to use the latest version however are blocked due to this bug.

@michaeltaranto michaeltaranto merged commit 64afabe into seek-oss:master Dec 1, 2021
@michaeltaranto
Copy link
Contributor

Apologies for taking so long to look at it. Thank for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltaranto michaeltaranto michaeltaranto approved these changes

@AndrewLeedham AndrewLeedham AndrewLeedham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 0.27.7 throws when no TS config file is found
5 participants
@pascalduez @danchristian @artmsilva @michaeltaranto @AndrewLeedham