-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing styles in build vs start #29
Comments
Any chance I could get a minimal reproduction of this issue somewhere? |
I'll find somewhere to put the dist out on the internet for the time being, will let you know when/where it is once I figure that out. E: Or did you want the src as well? |
Source is more important, so I can have a poke around at the build. |
https://github.com/patrickmarabeas/nothing-to-see-here/tree/stuff Pat has kindly donated a private repo so it's less likely I'll get fired out of a cannon in to the sun for doing this, haha. |
Thanks for letting me see your usage—the reproduction is a bit heavy, though, so I don't really have the time to dig in. Are you able to create a new project and reproduce the issue there? It'll probably help you narrow down exactly what's wrong, too. |
Yeah no probs, I'll have a look in to it tomorrow and see what I can pull out. |
https://github.com/patrickmarabeas/nothing-to-see-here Hopefully this is what you were looking for, it's only got our |
Is this an issue with styled-components? |
I think it could be, tried out manually running |
Upgrading to If you're interested in looking any further in to this go ahead but I'm happy to close it and move on and just wait until we are at a point that we can upgrade styled-components. |
Hi there,
I'm having all sorts of issues that I can't seem to pin down with my built assets not retaining a portion of their styles, using styled-components.
Eg:
![screen shot 2018-11-29 at 4 34 21 pm](https://user-images.githubusercontent.com/3507971/49201403-e4250000-f3f4-11e8-9a85-ee5f70a5c66e.png)
vs
My webpack config as is follows:
and frame component is:
Everything works perfectly using
start
but the built assets seem to lose some of their font-family, padding, and margin, while color and border seem to stay attached somehow. No webpack errors in the terminal while building, and the generated style tags in each frame's head are empty inbuild
, but full of expected classes etc instart
.The text was updated successfully, but these errors were encountered: