feat: Add initial TypeScript autocomplete support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great 🎉
|
|
One thing you might want to add is the ability to configure In my storybook i use that to exclude the HTML attributes using |
|
@hipstersmoothie I might look into something like this as a follow-up PR. |
|
Looks great, any ETA on when this will be released? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before starting webpack, if we detect a
tsconfig.jsonfile, we now use react-docgen-typescript to parse the prop types of all React components in the current working directory. For now, only string prop values are supported. On a component-by-component basis, we use the static types if they're available, otherwise we fall back to the existing strategy via parse-prop-types.There aren't any automated tests for this, but I've added a TypeScript example for manual testing. I've added a Cypress test for the existing autocomplete behaviour to ensure that we haven't regressed.
In order to test this automatically, we'll need to improve our test suite to support multiple test projects, but I'm happy to leave that for another PR.