Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Hooks support #49

Closed
loliver opened this issue Feb 21, 2019 · 4 comments · Fixed by #58
Closed

React Hooks support #49

loliver opened this issue Feb 21, 2019 · 4 comments · Fixed by #58

Comments

@loliver
Copy link
Contributor

loliver commented Feb 21, 2019

Hey there,

We're migrating all of our Recompose based components to Hooks over the next week or so and I've noticed we get the good old Hooks can only be called inside the body of a function component. (https://fb.me/react-invalid-hook-call) error when using hooks based components.

Happy to supply a PR once I'm finished our refactoring work.

Cheers.

@cneeson
Copy link

cneeson commented Apr 9, 2019

If you need any help putting together your second PR, let me know, would be happy to collaborate on this!

@loliver
Copy link
Contributor Author

loliver commented Apr 11, 2019

I'd love some help on it, not particularly experienced in this level of digging in to the internals of React and playroom isn't high on the priority list as far as my line managers are concerned unfortunately. The latest error boundaries work has helped tremendously but as soon as I try the basic update dependencies approach and use yarn link nothing works anymore.

@loliver
Copy link
Contributor Author

loliver commented Apr 15, 2019

@cneeson check out #58 and see if it works for your components.

@cneeson
Copy link

cneeson commented Apr 17, 2019

Works well for me @loliver, thanks for investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants