Review module and moduleResolution behaviour

[72636c]

Our base config currently sets moduleResolution to node:

skuba/config/tsconfig.json

Line 5 in 3bffa47

"moduleResolution": "node",

Per https://www.typescriptlang.org/docs/handbook/modules/reference.html#node10-formerly-known-as-node

--moduleResolution node was renamed to node10 (keeping node as an alias for backward compatibility) in TypeScript 5.0. It reflects the CommonJS module resolution algorithm as it existed in Node.js versions earlier than v12. It should no longer be used.

---

skuba build-package currently hardcodes modules:

skuba/src/cli/buildPackage.ts

Lines 9 to 20 in 3bffa47

	{
	command:
	'tsc --module CommonJS --outDir lib-commonjs --project tsconfig.build.json',
	name: 'commonjs',
	prefixColor: 'green',
	},
	{
	command:
	'tsc --module ES2015 --outDir lib-es2015 --project tsconfig.build.json',
	name: 'es2015',
	prefixColor: 'yellow',
	},

Per https://www.typescriptlang.org/docs/handbook/modules/reference.html#commonjs:

You probably shouldn’t use this [commonjs]. Use node16 or nodenext to emit CommonJS modules for Node.js.