vite/rollup: Return empty sourcemaps #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 64e07de The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattcompiles
reviewed
Jun 1, 2022
| const assetId = emittedFiles.get(importPath)!; | ||
| const assetName = this.getFileName(assetId); | ||
| const fixedImportPath = `./${normalize( | ||
| relative(chunkPath, assetName), | ||
| )}`; | ||
| return codeResult.replace(importPath, fixedImportPath); | ||
| }, code); | ||
| return { | ||
| code: output, | ||
| map: chunkInfo.map ?? null, |
There was a problem hiding this comment.
Is null handled differently than undefined?
There was a problem hiding this comment.
Yes it seems so. When I tested it chunkInfo.map actually was undefined and still resulted in the same warning. But with null it is suppressed.
mattcompiles
approved these changes
Jun 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
This suppresses the warnings in vite and rollup.
I'm not sure this is really what we want though. Logically this is wrong and the warning actually is correct.