Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Trim to 30sec #2

Closed
xanf-code opened this issue Dec 26, 2020 · 12 comments
Closed

Default Trim to 30sec #2

xanf-code opened this issue Dec 26, 2020 · 12 comments

Comments

@xanf-code
Copy link

Hey, first of all Wonderfull package : )

How do i keep the trim default to 30 seconds?
For Example, Whatsapp Status where a video longer than 30 seconds cannot be uploaded.

Thanks : )

@seel-channel
Copy link
Collaborator

There is no way to put a maximum duration, but in the next update I will add it

@xanf-code
Copy link
Author

That's nice, definitely helpful : ) !
Also what's with the drastic increase in the application size?

Before using the plugin the size of the application was around 23-24mb.

After adding the plugin the size skyrocketed to 85-90mb.

@seel-channel
Copy link
Collaborator

wow! I think it is by using external dependencies like the ffmpeg

@xanf-code
Copy link
Author

That's always been a problem with packages using ffmpeg. They do provide a quick fix tho where adding :

aaptOptions {
ignoreAssetsPattern "!x86:!*ffprobe"
}

this would cut down the size from 80-90 ish to around 50mb , which is still a lot for a 19-21mb application.

@seel-channel
Copy link
Collaborator

I think you can also reduce the weight by changing the ffmpeg package. For example from full-lts to min-lts

@xanf-code
Copy link
Author

I think you can also reduce the weight by changing the ffmpeg package. For example from full-lts to min-lts

I tried it as well, doesn't really change anything.

@Ahmed11300
Copy link

And please put in the next update to put the logo on the video

@xanf-code
Copy link
Author

And please put in the next update to put the logo on the video

Recommend you to open a new issue if any.

@seel-channel
Copy link
Collaborator

And please put in the next update to put the logo on the video

Please open a new Issue and explain to me with more details.

@GSPrakashNaidu
Copy link

GSPrakashNaidu commented Jan 8, 2021

Hi,

This plugin looks really cool...

@xanf-code, @seel-channel we can use some part of code from https://pub.dev/packages/video_trimmer package. If this is the case even I will also work on this.

Thanks :)

@xanf-code
Copy link
Author

Hi,

This plugin looks really cool...

@xanf-code, @seel-channel we can use some part of code from https://pub.dev/packages/video_trimmer package. If this is the case even I will also work on this.

Thanks :)

Yes, exactly.

And the issue with the space has to be solved ASAP I guess. Even the most minimum version of FFMPEG is increasing the app size by >20mb :/

seel-channel pushed a commit that referenced this issue Jan 14, 2021
@seel-channel
Copy link
Collaborator

seel-channel commented Jan 14, 2021

I added the TrimSlider max duration argument. If you want to set a 30seconds max duration as WhatsApp, you do this:

TrimSlider (maxDuration: Duration (seconds: 30));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants