Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dependencies] Upgrade ffmpeg_kit_flutter_min_gpl to stable version #81

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[dependencies] Upgrade ffmpeg_kit_flutter_min_gpl to stable version #81

merged 2 commits into from
Mar 30, 2022

Conversation

adigladi
Copy link
Contributor

Issue #80

  • Sets dependency to ^4.5.1

@adigladi adigladi force-pushed the dependencies/upgrade-to-stable-versions branch 3 times, most recently from 545ee56 to f8a73c0 Compare March 29, 2022 14:02
@LeGoffMael
Copy link
Owner

Thank you so much for your contribution !

Like discussed in the related issue (#80), i don't think that removing the path package is necessary (correct me if you think differently).

To be perfectly all right, the platform target in example/ios/Podfile should be updated to 12.1, (android target sdk is already good) -> cf ffmpeg_kit doc.

If you removed your last commit and update the example ios target version i would be more than happy to accept your PR :D.

@adigladi adigladi force-pushed the dependencies/upgrade-to-stable-versions branch 2 times, most recently from 4d06abb to 5e9d0e5 Compare March 30, 2022 08:16
@adigladi adigladi force-pushed the dependencies/upgrade-to-stable-versions branch from 28328fe to f38004d Compare March 30, 2022 08:18
@adigladi
Copy link
Contributor Author

Thanks! Okay, I added back the path dependency and updated the platform target 👍

@LeGoffMael LeGoffMael merged commit e593966 into LeGoffMael:master Mar 30, 2022
@LeGoffMael
Copy link
Owner

Merged! Thank you for your contribution

@LeGoffMael LeGoffMael mentioned this pull request Mar 30, 2022
Closed
@adigladi adigladi deleted the dependencies/upgrade-to-stable-versions branch March 30, 2022 11:57
rohanspyn added a commit to spynai/video_editor that referenced this pull request Mar 31, 2022
@rohanspyn
Squashed commit of the following:
d33eaf5 
commit e593966
Merge: 7be25f5 f38004d
Author: Maël <legoffmael@gmail.com>
Date:   Wed Mar 30 20:43:05 2022 +0900

    Merge pull request LeGoffMael#81 from adigladi/dependencies/upgrade-to-stable-versions

    [dependencies] Upgrade ffmpeg_kit_flutter_min_gpl to stable version

commit f38004d
Author: adigladi <adigladi@hotmail.com>
Date:   Wed Mar 30 10:13:48 2022 +0200

    Update platform target

commit 77032c6
Author: adigladi <adigladi@hotmail.com>
Date:   Tue Mar 29 12:02:55 2022 +0200

    [dependencies] Upgrade ffmpeg_kit to stable ver

commit 7be25f5
Author: Maël Le Goff <legoffmael@gmail.com>
Date:   Tue Mar 29 20:23:17 2022 +0900

    [release] ready to 1.2.5

commit fade639
Author: Maël Le Goff <legoffmael@gmail.com>
Date:   Tue Mar 29 20:19:09 2022 +0900

    [dependencies] fix path issue + upgrade video_thumbnail

commit 18634fd
Author: Maël Le Goff <legoffmael@gmail.com>
Date:   Tue Mar 29 20:03:46 2022 +0900

    [clean] ignore and remove pubspec.lock

commit ff376b1
Author: Maël Le Goff <legoffmael@gmail.com>
Date:   Tue Mar 29 19:54:52 2022 +0900

    [clean] delete useless pubspec.lock

commit 8ed3919
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 18 13:57:47 2022 +0900

    [clean] remove useless dependency

commit 2b384eb
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 18:32:09 2022 +0900

    [release] update to 1.2.4

commit 2f72a88
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 18:27:58 2022 +0900

    [new] add isFiltersEnabled param to extractCover

commit 63746c7
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 18:10:37 2022 +0900

     add todo related to crop fix

commit 3890088
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 17:52:32 2022 +0900

    [dependencies] upgrade dependencies to latest

commit a956b80
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 15:06:04 2022 +0900

    update readme screenshots

commit c6a5d4b
Author: Mael Le Goff <m.legoff@xenoimpact.com>
Date:   Fri Mar 11 14:57:17 2022 +0900

    doc - improve readme
LeGoffMael pushed a commit that referenced this pull request Apr 1, 2022
[example] update android conf following #81
0c0ab72
LeGoffMael added a commit that referenced this pull request Apr 1, 2022
@LeGoffMael
[doc] add explanation about LTS release #81
dfd48b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adigladi @LeGoffMael