New feature video cover selection #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
July 29, 2021 10:50
|
Bro, I've just merged the pull request #28 and it generated a conflict |
…into pull_request_cover_selection
|
Hey ! I merged the new master into my branch they should not be any conflict anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull_request includes new widgets allowing the user to select his favorite thumbnail between an automatic selection.
I think this could be a good feature to include in this package because I haven't found any other library doing it. But it's a feature that you can find on Youtube or Instagram for example. All transformation data is also shared with these new widgets.
New feature
xamount of thumbnails from the trimmed period usingvideo_thumbnaillibrary.ffmpegGeneral changes
CoverSelectionandCoverViewercover_feature_example.mp4
Solution explanation
Originally, I had planned to select the cover like in the Instagram interface while using the video player, but it looks like Flutter
video_player'sseekTo()function is not instantaneous and does not work properly when the video is paused (#61004,#80054).So I preferred to generate a fixed number of thumbnails each time the video is trimmed, so that the user can select his favorite thumbnail.