Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exportation directory issues + add exportation parameters (cover format and exportation directory) #47

Merged
merged 3 commits into from
Oct 31, 2021

Conversation

LeGoffMael
Copy link
Owner

  • Fix exporting path missing / after the exporting directory for video and cover causing the final path to be /var/mobile/Containers/Data/Application/.../Library/Cachestrim.jpg instead of /var/mobile/Containers/Data/Application/.../Library/Caches/trim.jpg
  • Fix the way to get the video file name during exportation to use path.basenameWithoutExtension(file.path) instead path.basename(file.path).split('.')[0] because when the file has a . in it name the final name is not correct
  • Add parameter to specify exporting folder with outDir for video and cover exportation support for custom export outPath #40 (comment)
  • Add parameter to specify the format of the cover to be exported (by default jpg)
  • remove TODO comment because ffmpeg -y overwrite works properly
  • display exported cover in example

@seel-channel seel-channel merged commit 0af48f2 into LeGoffMael:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants