Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how video dimensions are computed + update example and libraries #48

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Change how video dimensions are computed + update example and libraries #48

merged 6 commits into from
Nov 1, 2021

Conversation

LeGoffMael
Copy link
Owner

In lib:

  • Currently the video dimensions are computed using ffmpeg, i think it is a heavy implementation that could be done easily using VideoPlayerController
await _video.initialize().then((_) {
  _videoWidth = _video.value.size.width;
  _videoHeight = _video.value.size.height;
});
  • Add the option to change the No selection text in CoverViewer
  • Update video_player library to the latest 2.2.6

In example:

  • Display exported video
  • Add video_player library
  • Update image_picker library to the latest 0.8.4 and update code to remove deprecated implementation

@seel-channel seel-channel merged commit 80e1262 into LeGoffMael:master Nov 1, 2021
@LeGoffMael LeGoffMael deleted the bug-fixes-2 branch November 4, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants