Remove keystone backlight in ambiant mode.

[Kowken]

Describe the bug
When I use ambiant backlight mode, my keystone light (that one red LED that is supposed to shine when I plug the keystone magnetic chip on the right side of my computer lights up and does not get off after changing mode

Clear scenario to Reproduce
Steps to reproduce the behavior:

1. Go to the keyboard section
2. Click on 'ambiant'
3. The keystone LED will light up alongside the other keys of the keyboard.
4. Change backlight mode
5. The keystone light will stay on regardless

Expected behavior
The keystone is supposed to go off in that case and not even be lit up in the first place when using any backlight mode.

Solution proposition
Try to remove the Keystone LED from the equation using OpenRGB documentation since this application can control this peculiar light at will (tested).
Briefly deactivate all lights when switching between backlight modes to make sure that this light does not stay on outside of this peculiar case.
The latter solution can work for sure because this is what I do when I want to desactivate this light:

• I switch to the static layout, which applies the color only once
• I use openRGB to put on a new static layout,
  which effectively removes the keystone light
• I put back the mode I wanted to use from GHelper

App Logs
Please include and attach log.txt from %AppData%\GHelper
log.txt

Screenshots or screencasts
I can't use my phone at the moment but will tomorrow.

Desktop (please complete the following information):

• OS: Windows 11 23H2
• ASUS ROG STRIX SCAR 15 (2022) G533ZW AS94

Asus software

• Armoury Crate not installed
• MyASUS not installed
• NoAsus services running in background

Additional context
This issue is similar to the #967 and the soluton was using the old heatmap from 0.102 which excluded this specific LED.

[seerge]

@Kowken hello

As I previously tried to explain you, I don't own a Strix device with per-led RGB. And from practical standpoint implementing proper RGB control in the app while being de-facto "blind" is almost impossible.

I have just moved 1 to 1 per-key color setting from OpenRGB https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/AsusAuraCoreController/AsusAuraCoreLaptopController.cpp

This build will send USB packets in a way, it's done in OpenRGB. You can test both Heatmap / Ambient modes, they should just set a single color to whole keyboard (per-key)

GHelper.zip

However I have zero idea if it will even work.

[Kowken]

@Kowken hello

As I previously tried to explain you, I don't own a Strix device with per-led RGB. And from practical standpoint implementing proper RGB control in the app while being de-facto "blind" is almost impossible.

I have just moved 1 to 1 per-key color setting from OpenRGB https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/AsusAuraCoreController/AsusAuraCoreLaptopController.cpp

This build will send USB packets in a way, it's done in OpenRGB. You can test both Heatmap / Ambient modes, they should just set a single color to whole keyboard (per-key)

GHelper.zip

However I have zero idea if it will even work.

Yeah I knew that but can the solution where you briefly turn all lights off before applying the next profile be implemented (like a 1 ms black static profile) ? I just want the Keystone LED to turn off after I changed the profile (I don't really care that much if ambient has the keystone light on as long as it is kept there)

[seerge]

Does the build I linked make any difference ?

[Kowken]

The zip you sent me does not solve the issue

Does the build I linked make any difference ?

[seerge]

Ok, thanks for trying.

Then I can't help here anyhow. You are free to contribute and do a PR with a fix.

Thanks

[Kowken]

Ok, thanks for trying.

Then I can't help here anyhow. You are free to contribute and do a PR with a fix.

Thanks

Is there no way to just turn off all backlights before applying another profile or is this what you did in the zip you just sent me ?

[seerge]

No. As I have explained I have moved per-key setting implementation from OpenRGB to G-Helper.

It was not supposed to turn off your special light. But it was supposed to set only needed (main keys) backlights in a first place.

You need to find a way to turn special key somehow else first.

[Kowken]

No. As I have explained I have moved per-key setting implementation from OpenRGB to G-Helper.

It was not supposed to turn off your special light. But it was supposed to set only needed (main keys) backlights in a first place.

You need to find a way to turn special key somehow else first.

Okay thank you for trying.
I will just report that once activated, the keystone light will sync with all other lights: it will pulse with pulse mode or change the proportion of red according to the color created by RGB.
So like it gets synched into any color profile as soo as it is first enabled by ambient or current heatmap mode.
I will try to find a solution on my side as well.
Take care and have a nice day.

[Kowken]

@seerge I found something: disabling the logo light will also disable the keystone one (no other backlight enables this) so the two are linked I guess.

EDIT: This behavior only works with the build you just sent to me.

[seerge]

@Kowken does it mean that Ambient / Heatmap in the build i linked don't turn ON keystone ?

[Kowken]

@Kowken does it mean that Ambient / Heatmap in the build i linked don't turn ON keystone ?

No it does mean that once it has been activated, it can be disabled when and as long as I disable the logo lights. It is enabled again if I re-enable the logo light, regardless of the current backlight mode. I could not do that in 0.133.

EDIT: Also Heatmap and Ambient mode are quite glitchy in the build you sent: Heatmap can take a bit to fully activate (though that's not really an issue), but ambient mode looks like an almost extinguished heatmap insted of the usual one.

[seerge]

@Kowken does this build turns off keystone?
GHelper.zip

[Kowken]

@Kowken does this build turns off keystone? [GHelper.zip](https://github.com/seerge/g-helper/files/13404367/GHelper.zip

Yes it does work !
Ambient lighting looks a bit weird though:it's more of a general lighting regarding what I am displaying than the one where you have keys with other colors sparkling from time to time (I'll send a picture right away). Also heatmap takes about a second to set up (not complaining, just stating facts btw).

[Kowken]

@Kowken does this build turns off keystone? [GHelper.zip](https://github.com/seerge/g-helper/files/13404367/GHelper.zip

Yes it does work !

Ambient lighting looks a bit weird though:it's more of a general lighting regarding what I am displaying than the one where you have keys with other colors sparkling from time to time (I'll send a picture right away). Also heatmap takes about a second to set up (not complaining, just stating facts btw).

Here are the pictures (first from 0.133 and then from current build):

[seerge]

@Kowken try this build,

It should have 4 zones for ambient colors + lightbar

GHelper.zip

[Kowken]

@Kowken try this build,

It should have 4 zones for ambient colors + lightbar

GHelper.zip

I will try it in about 30 minutes (sorry for the delay).

[Kowken]

@Kowken try this build,

It should have 4 zones for ambient colors + lightbar

GHelper.zip

Yes there are the four aformentioned zones from left to right.

[seerge]

@Kowken Do you mind posting a photo ? as i have manually assigned keys to zones

[Kowken]

@Kowken Do you mind posting a photo ? as i have manually assigned keys to zones

[seerge]

@Kowken Oke, thanks. Looks more or less legit as for me.

I have reassigned F5 and 6 buttons, a bit in this build
GHelper.zip

Closing as completed then

[Kowken]

@Kowken Oke, thanks. Looks more or less legit as for me.

I have reassigned F5 and 6 buttons, a bit in this build GHelper.zip

Closing as completed then

Great ! Thank you so much !

[Kowken]

Will this change be implemented into the next master releases btw ?

EDIT: Never mind my question, I saw the implementation in 0.134

[seerge]

It's already live in 0.134