Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes if the app tries to elevate rights to admin but the user cancels #593

Closed
danielcandea opened this issue Jun 10, 2023 · 3 comments

Comments

@danielcandea
Copy link

If the app doesn't run as admin and there is an action which requires admin rights, if the user presses No in UAC, the app crashes.

I can reproduce this on my 2021 Zephyrus G14, model GA401QM, running G-Helper v0.8.2 on an up-to-date Windows 11. Every time I go to Extra form and press the Stop button for Asus services and get the UAC prompt and press No, the app crashes.

I have a patch for this which works on my machine and would like to create a PR but can't push my branch into the repo. How can I proceed? Do I need to fork the repo and create a PR from my fork?

@seerge
Copy link
Owner

seerge commented Jun 10, 2023

@danielcandea i will fix it by myself :) thanks for spotting.

@seerge
Copy link
Owner

seerge commented Jun 10, 2023

@danielcandea this build should fix it
GHelper.zip

@danielcandea
Copy link
Author

@seerge The change fixed the issue, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants