Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of is_coprime.num_denom once it is merged in mathlib #22

Closed
1 of 2 tasks
jcpaik opened this issue Mar 25, 2023 · 1 comment · Fixed by #44
Closed
1 of 2 tasks

Get rid of is_coprime.num_denom once it is merged in mathlib #22

jcpaik opened this issue Mar 25, 2023 · 1 comment · Fixed by #44

Comments

@jcpaik
Copy link
Collaborator

jcpaik commented Mar 25, 2023 •
edited
Loading

leanprover-community/mathlib#18652

As this PR in mathlib is merged,

  • Update mathlib version
  • and get rid of is_coprime.num_denom in the proof of elliptic curve parametrization.
@jcpaik
Copy link
Collaborator Author

jcpaik commented Jun 26, 2024

The PR has been merged and we should incorporate this lemma in our code.

This was referenced Jun 27, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace isCoprime.num_denom with existing one seewoo5/lean-poly-abc
1 participant
@jcpaik