Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Analytics: Test failures (causing master to fail) #645

Closed
ndhoule opened this issue Jun 2, 2015 · 1 comment
Closed

Google Analytics: Test failures (causing master to fail) #645

ndhoule opened this issue Jun 2, 2015 · 1 comment
Assignees
@ndhoule
Labels
bug

Comments

@ndhoule
Copy link
Contributor

ndhoule commented Jun 2, 2015

Google Analytics changed some internal implementation details and now our tests are failing, causing the entire project to fail. These tests don't actually indicate a failure of the integration, but rather an inappropriate intimacy problem in our tests.

Tests should be refactored to test the GA interface, not its internal mechanisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndhoule ndhoule

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndhoule