You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be helpful for your object return types, particularly in the AnalyticsLibraryNameIntegrationFactory methods, to return instancetype instead of id.
There's a longer, better explanation at NSHipster, but the short version is that instancetype is type-safe ("This will only ever be this type of object") and id is not ("What kind of object is this? ¯\_(ツ)_/¯"). This enhancement would be particularly helpful in integrating with Swift code, but it's best practice even in Obj-C.
Note: I've only filed this on this particular integration, but it'd probably be wise to update this across all your integrations.
The text was updated successfully, but these errors were encountered:
It would be helpful for your object return types, particularly in the
AnalyticsLibraryNameIntegrationFactory
methods, to returninstancetype
instead ofid
.There's a longer, better explanation at NSHipster, but the short version is that
instancetype
is type-safe ("This will only ever be this type of object") andid
is not ("What kind of object is this?¯\_(ツ)_/¯
"). This enhancement would be particularly helpful in integrating with Swift code, but it's best practice even in Obj-C.Note: I've only filed this on this particular integration, but it'd probably be wise to update this across all your integrations.
The text was updated successfully, but these errors were encountered: