extremely rare race condition in identify function can slightly degrade data consistency

[reinpk]

Instead of serialQueue, pass it the userId in to the enqueueAction method: https://github.com/segmentio/analytics-ios/blob/master/Analytics/Analytics/Source/Segmentio/Segmentio.m#L140-L142

[tonyxiao]

What's the correct behavior here? If we look at https://github.com/segmentio/analytics-ios/blob/dev/Analytics/Providers/Segmentio/SegmentioProvider.m#L158 , it seems that the intention is we should always send the most up to date userId regardless of what the userID might have been when track: is called, which is why we don't set the userID and sessionID on the payload until we are inside the serialQueue, however the identify function at https://github.com/segmentio/analytics-ios/blob/dev/Analytics/Providers/Segmentio/SegmentioProvider.m#L103 seems to defeat the above mechanism by setting self.userID also inside the serialQueue. Since they contradict each other, the natural question is what should the correct behavior be?

[reinpk]

oh man. i'm totally not sure. let's hold on this issue until we can talk to the mailbox guys again. i've completely forgotten what the bad scenario was :P

[tonyxiao]

Do we have a better idea what is the desired behavior?

[tonyxiao]

Ok desired behavior is that identify calls shouldn't affect track calls currently in the queue. Solved and closing.