Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

This module has side effect of leaking window._ (set to lodash) #48

Closed
cymen opened this issue Nov 6, 2015 · 5 comments
Closed

This module has side effect of leaking window._ (set to lodash) #48

cymen opened this issue Nov 6, 2015 · 5 comments

Comments

@cymen
Copy link

cymen commented Nov 6, 2015

This module has a side effect of leaking to window._ with it set to lodash.

@cymen
Copy link
Author

cymen commented Nov 6, 2015

Also I get this is intended for node server side but where is the Segment IO node module for client-side development? Maybe it's https://github.com/segmentio/analytics.js? I'll go try that but it would be great if analytics-node was targeted at both server and client side (and if it is supposed to be, that the leakage to window._ was fixed).

@hankim813
Copy link

The core logic for client side would be https://github.com/segmentio/analytics.js-core but the open sourced version is indeed at https://github.com/segmentio/analytics.js

@f2prateek
Copy link
Contributor

Reopening since this is still an issue.

@f2prateek f2prateek reopened this Nov 22, 2016
@vadimdemedes
Copy link

Will be fixed when #110 is merged, since it removes lodash altogether.

@vadimdemedes
Copy link

New release is out - https://github.com/segmentio/analytics-node/releases/tag/v3.0.0, which doesn't use lodash anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants