Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Build Facebook App Events Destination plugin #113

Closed
jfrodden opened this issue Jan 28, 2022 · 7 comments
Closed

Feature Request: Build Facebook App Events Destination plugin #113

jfrodden opened this issue Jan 28, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@jfrodden
Copy link

jfrodden commented Jan 28, 2022

Is your feature request related to a problem? Please describe.
We're trying to migrate away from CocoaPods towards Swift Package Manager for our dependency management and the lack of SPM support of FacebookAppEvents is blocking us from completing that goal.

Describe the solution you'd like
We'd like to migrate all of our dependency management to Swift Package Manager, including Segment FacebookAppEvents

Describe alternatives you've considered
Our only option is to continue using CocoaPods for all our Segment, Facebook, and GoogleAnalytics/Firebase needs because Segment FacebookAppEvents pulls all the others in via CocoaPods and trying to import them both via CocoaPods and SPM creates build issues.

@bsneed bsneed added enhancement New feature or request and removed triage labels Jan 28, 2022
@bsneed
Copy link
Contributor

bsneed commented Jan 28, 2022

Thanks @jfrodden!

If I were to write this for you over the next couple of days, would you be able to test it?

@jfrodden
Copy link
Author

jfrodden commented Jan 28, 2022

a qualified yes: modulo any other issues we encounter with moving the other libraries over to SPM (since they all seem to need to move in lock-step), along with any issues we encounter moving to the new (still in beta) version of segment sdk

@bsneed
Copy link
Contributor

bsneed commented Jan 28, 2022

Excellent, I'll take a stab at it and let you know when I've got something for you to try.

Thanks so much @jfrodden !

@bsneed
Copy link
Contributor

bsneed commented Feb 16, 2022

@jfrodden please see changes in #118 and lemme know how they work for you! Thanks so much!

@bsneed bsneed closed this as completed Feb 16, 2022
@jfrodden
Copy link
Author

@jfrodden please see changes in #118 and lemme know how they work for you! Thanks so much!

I'm able to add this repo via SPM now, but we also rely on other Segment related libraries which trigger some sort of conflict with this version:

Any pointers on how to get all this functionality to co-exist via SPM would be greatly appreciated.

@bsneed
Copy link
Contributor

bsneed commented Feb 24, 2022

Heya @jfrodden

You can't mix analytics-swift and analytics-ios in the same codebase. Has to be one or the other. There's destination plugins for both of those in the analytics-swift repo under the /examples folder already.

@bsneed
Copy link
Contributor

bsneed commented Feb 24, 2022

@jfrodden also of note, we're working on making some of these destinations shown in the examples folder actual supported components with their own repos and packages. In the meantime, you should be able to copy the destinations you need from the examples folder to your own codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants