Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content script execution problem? #46

Open
International opened this issue Oct 4, 2017 · 0 comments
Open

Content script execution problem? #46

International opened this issue Oct 4, 2017 · 0 comments

Comments

@International
Copy link

Hi!

I tried the extension and I am curious about the behaviour of the content script. I tried to run the extension on a react app, and I noticed that it could not record me typing stuff into the input box.

I've added a few console.log statements to see what's happening, and this part:

    const inputs = document.querySelectorAll('input, textarea')
    console.log('inputs', inputs)

returns 0. Basically, it means that it tries to bind the listeners before the react app has actually booted, hence no inputs exist on the page.

Is there a reason why the extension works this way? Wouldn't it be better for the content script to bind listeners only once the badge has been clicked? At least the user would be aware whether or not DOM has completely loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant