Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go dep and kafka-go #103

Closed
maxim-ge opened this issue Jun 8, 2018 · 6 comments
Closed

go dep and kafka-go #103

maxim-ge opened this issue Jun 8, 2018 · 6 comments

Comments

@maxim-ge
Copy link

maxim-ge commented Jun 8, 2018

For project which uses kafka-go dep init results into:

[[constraint]]
  branch = "master"
  name = "github.com/segmentio/kafka-go"

Whereas sarama:

[[constraint]]
  name = "github.com/Shopify/sarama"
  version = "1.16.0"

Don't you have an intent to pin down first version somehow?

@maxim-ge maxim-ge changed the title go dep anf kafka-go go dep and kafka-go Jun 8, 2018
@f2prateek
Copy link

This is likely because we haven't cut a tag yet.

@maxim-ge
Copy link
Author

maxim-ge commented Jun 21, 2018 via email

@f2prateek
Copy link

I don't think we're ready to cut a v1 yet #96 (comment).

@maxim-ge
Copy link
Author

maxim-ge commented Jun 21, 2018 via email

@collinvandyck
Copy link
Contributor

@maxim-ge in the meanwhile, dep allows you to specify a revision for a constraint. at least this way you could pin it to a commit in the absence of a tag.

@maxim-ge
Copy link
Author

@collinvandyck - you are right, missed this option, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants