Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageTooLargeError is not conforming to errors.Is #1293

Open
Tang8330 opened this issue May 21, 2024 · 0 comments
Open

MessageTooLargeError is not conforming to errors.Is #1293

Tang8330 opened this issue May 21, 2024 · 0 comments
Labels

Comments

@Tang8330
Copy link

Tang8330 commented May 21, 2024

Describe the bug

A clear and concise description of what the bug is.

The Kafka message too large error can not be asserted via errors.Is

Kafka Version

  • What version(s) of Kafka are you testing against?

3.5.1

  • What version of kafka-go are you using?

v0.4.47

Additional Context

Add any other context about the problem here.

We are unable to use errors.Is(err, kafka.MessageSizeTooLarge) because the function is returning another struct. See this PR for more context: artie-labs/reader#396

@Tang8330 Tang8330 added the bug label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant