Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Fullpage diff #21

Closed
alanpilloud opened this issue Apr 4, 2018 · 1 comment
Closed

Fullpage diff #21

alanpilloud opened this issue Apr 4, 2018 · 1 comment

Comments

@alanpilloud
Copy link

What needs to get done?

I'm trying to solve issue #18 (taking fullpage screenshots). I've managed to capture fullpage screenshots. However, the diff doesn't run up to 2144px of height.

Anyone has an idea why the diff does not process the whole page ?

Why does it need to get done?

How do I do it?

Setup
  • Clone the repo by running git clone https://github.com/alanpilloud/niffy
  • Run npm install
  • Run tests with make tests (tests will "fail" for now, as expected)
  • Go check the diff for the page /services
@alanpilloud
Copy link
Author

I've tried to implement modifications in the pull request #20 and now it is working 😄
I'll open a new pull request indicating that it is dependent on #20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant