asynchronous evaluate #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature would be really awesome! |
|
@rosshinkley this pull request is great! Thank you. It will help me with #830 |
|
Including. Thanks for the feedback. :) |
This was referenced Oct 20, 2016
Closed
Closed
|
I think this PR can help me. Can someone please show me an example of how to resolve this? #1279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to let you run
.evaluate()d functions that are asynchronous, either with callbacks or with promises. For callbacks, if the.evaluate()d function's arity is one less than the passed in parameters, it'll assume the last argument to the function is the callback. If the return value is athenable, it'll callthen()to wait for promise fulfillment. Otherwise, the call will behave synchronously as it does now.This change is potentially breaking as it does change behavior based on the arguments to
.evaluate(). Is this change worth the risk of possibly breaking implementations that already exist?Related to #573 and closes #552.