Replace gometalinter with golangci-lint. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt values are presented as JSON.
Add support for default values for variable types list and map.
Literal types remain unquoted in pretty presentation. Simplify code.
Fix printing of '-' for required variables.
Type is optional (https://www.terraform.io/docs/configuration/variables.html#type), so infer the type when possible. This fixes panics for cases like: ``` variable "foo" { default = [] } ```
Add support for type inference
metmajer
force-pushed
the
add-golangci-lint
branch
from
da047a7
to
4f1d27e
Compare
This was referenced Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:For more information, see the Contributing Guide.
Description
This PR replaces gometalinter with the more performance alternative golangci-lint.
Checklist
Put an
xinto all boxes that apply:Tests
make test.Documentation
Code Style