Fix missing deps make target #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Docker image calls `make deps`, so the target was re-added to maintain backward compatibility. * Fixes terraform-docs#125 * Sorted vendor module list
khos2ow
reviewed
Sep 29, 2019
| @@ -55,6 +55,9 @@ clean: ## Clean workspace | |||
| @ $(MAKE) --no-print-directory log-$@ | |||
| rm -rf ./$(BUILD_DIR) | |||
|
|
|||
| .PHONY: deps | |||
There was a problem hiding this comment.
Nice catch, but can you rename the deps in all target to vendor instead of creating new one?
There was a problem hiding this comment.
You mentioned this target is being used in an external scripts and Docker image. Can you link any of those for reference here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:For more information, see the Contributing Guide.
Description
Describe what this pull request achieves. Ensure you have read the Contributing Guidelines document before submitting.
The deps target was removed from the makefile, but is still used by external scripts. Re-added as a link to the vendor target to maintain backward compatibility.
Issues Resolved
List any existing issues this pull request resolves.
Fixes #125
Checklist
Put an
xinto all boxes that apply:Tests
make test.Documentation
Code Style