Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new go linters and fix the existing issues #132

Merged
merged 5 commits into from
Dec 13, 2019
Merged

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Dec 13, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

This PR enables new go linters and fixes the existing issues for some of them. The list of enabled linters are:

  • govet
  • golint
  • misspell
  • varcheck
  • structcheck
  • staticcheck
  • errcheck
  • unconvert
  • unused

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow merged commit c11ab16 into master Dec 13, 2019
@khos2ow khos2ow deleted the new-linters branch December 13, 2019 22:00
@khos2ow khos2ow added this to the v0.8.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant